| From d74f9747b3aa817479d9408efecdcba1ad5eb7c9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 16 Jun 2021 12:25:34 +0800 |
| Subject: samples/bpf: Fix the error return code of xdp_redirect's main() |
| |
| From: Wang Hai <wanghai38@huawei.com> |
| |
| [ Upstream commit 7c6090ee2a7b3315410cfc83a94c3eb057407b25 ] |
| |
| Fix to return a negative error code from the error handling |
| case instead of 0, as done elsewhere in this function. |
| |
| If bpf_map_update_elem() failed, main() should return a negative error. |
| |
| Fixes: 832622e6bd18 ("xdp: sample program for new bpf_redirect helper") |
| Signed-off-by: Wang Hai <wanghai38@huawei.com> |
| Signed-off-by: Andrii Nakryiko <andrii@kernel.org> |
| Link: https://lore.kernel.org/bpf/20210616042534.315097-1-wanghai38@huawei.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| samples/bpf/xdp_redirect_user.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c |
| index 1ddac4bcf447..3c92adc2a7bd 100644 |
| --- a/samples/bpf/xdp_redirect_user.c |
| +++ b/samples/bpf/xdp_redirect_user.c |
| @@ -219,5 +219,5 @@ int main(int argc, char **argv) |
| poll_stats(2, ifindex_out); |
| |
| out: |
| - return 0; |
| + return ret; |
| } |
| -- |
| 2.30.2 |
| |