| From 40445fd2c9fa427297acdfcc2c573ff10493f209 Mon Sep 17 00:00:00 2001 |
| From: Javed Hasan <jhasan@marvell.com> |
| Date: Thu, 3 Jun 2021 03:14:03 -0700 |
| Subject: scsi: fc: Correct RHBA attributes length |
| |
| From: Javed Hasan <jhasan@marvell.com> |
| |
| commit 40445fd2c9fa427297acdfcc2c573ff10493f209 upstream. |
| |
| As per the FC-GS-5 specification, attribute lengths of node_name and |
| manufacturer should in range of "4 to 64 Bytes" only. |
| |
| Link: https://lore.kernel.org/r/20210603101404.7841-2-jhasan@marvell.com |
| Fixes: e721eb0616f6 ("scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions") |
| CC: stable@vger.kernel.org |
| Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> |
| Signed-off-by: Javed Hasan <jhasan@marvell.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| include/scsi/fc/fc_ms.h | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/include/scsi/fc/fc_ms.h |
| +++ b/include/scsi/fc/fc_ms.h |
| @@ -63,8 +63,8 @@ enum fc_fdmi_hba_attr_type { |
| * HBA Attribute Length |
| */ |
| #define FC_FDMI_HBA_ATTR_NODENAME_LEN 8 |
| -#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 80 |
| -#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80 |
| +#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 64 |
| +#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 64 |
| #define FC_FDMI_HBA_ATTR_MODEL_LEN 256 |
| #define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256 |
| #define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256 |
