| From 11b1d881a90fc184cc7d06e9804eb288c24a2a0d Mon Sep 17 00:00:00 2001 |
| From: Ondrej Zary <linux@zary.sk> |
| Date: Fri, 11 Jun 2021 22:19:39 +0200 |
| Subject: serial_cs: remove wrong GLOBETROTTER.cis entry |
| |
| From: Ondrej Zary <linux@zary.sk> |
| |
| commit 11b1d881a90fc184cc7d06e9804eb288c24a2a0d upstream. |
| |
| The GLOBETROTTER.cis entry in serial_cs matches more devices than |
| intended and breaks them. Remove it. |
| |
| Example: # pccardctl info |
| PRODID_1="Option International |
| " |
| PRODID_2="GSM-Ready 56K/ISDN |
| " |
| PRODID_3="021 |
| " |
| PRODID_4="A |
| " |
| MANFID=0013,0000 |
| FUNCID=0 |
| |
| result: |
| pcmcia 0.0: Direct firmware load for cis/GLOBETROTTER.cis failed with error -2 |
| |
| The GLOBETROTTER.cis is nowhere to be found. There's GLOBETROTTER.cis.ihex at |
| https://netdev.vger.kernel.narkive.com/h4inqdxM/patch-axnet-cs-fix-phy-id-detection-for-bogus-asix-chip#post41 |
| It's from completely diffetent card: |
| vers_1 4.1, "Option International", "GSM/GPRS GlobeTrotter", "001", "A" |
| |
| Signed-off-by: Ondrej Zary <linux@zary.sk> |
| Cc: stable <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/20210611201940.23898-1-linux@zary.sk |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/tty/serial/8250/serial_cs.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/tty/serial/8250/serial_cs.c |
| +++ b/drivers/tty/serial/8250/serial_cs.c |
| @@ -808,7 +808,6 @@ static const struct pcmcia_device_id ser |
| PCMCIA_DEVICE_CIS_PROD_ID12("ADVANTECH", "COMpad-32/85B-4", 0x96913a85, 0xcec8f102, "cis/COMpad4.cis"), |
| PCMCIA_DEVICE_CIS_PROD_ID123("ADVANTECH", "COMpad-32/85", "1.0", 0x96913a85, 0x8fbe92ae, 0x0877b627, "cis/COMpad2.cis"), |
| PCMCIA_DEVICE_CIS_PROD_ID2("RS-COM 2P", 0xad20b156, "cis/RS-COM-2P.cis"), |
| - PCMCIA_DEVICE_CIS_MANF_CARD(0x0013, 0x0000, "cis/GLOBETROTTER.cis"), |
| PCMCIA_DEVICE_PROD_ID12("ELAN DIGITAL SYSTEMS LTD, c1997.", "SERIAL CARD: SL100 1.00.", 0x19ca78af, 0xf964f42b), |
| PCMCIA_DEVICE_PROD_ID12("ELAN DIGITAL SYSTEMS LTD, c1997.", "SERIAL CARD: SL100", 0x19ca78af, 0x71d98e83), |
| PCMCIA_DEVICE_PROD_ID12("ELAN DIGITAL SYSTEMS LTD, c1997.", "SERIAL CARD: SL232 1.00.", 0x19ca78af, 0x69fb7490), |