| From 41dd73ffae5d7c0809e5b6f1719a9bc4e7a7d55b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 13 Jun 2021 13:29:16 +0800 |
| Subject: spi: meson-spicc: fix memory leak in meson_spicc_probe |
| |
| From: zpershuai <zpershuai@gmail.com> |
| |
| [ Upstream commit b2d501c13470409ee7613855b17e5e5ec4111e1c ] |
| |
| when meson_spicc_clk_init returns failed, it should goto the |
| out_clk label. |
| |
| Signed-off-by: zpershuai <zpershuai@gmail.com> |
| Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> |
| Link: https://lore.kernel.org/r/1623562156-21995-1-git-send-email-zpershuai@gmail.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/spi/spi-meson-spicc.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c |
| index 51aef2c6e966..b2c4621db34d 100644 |
| --- a/drivers/spi/spi-meson-spicc.c |
| +++ b/drivers/spi/spi-meson-spicc.c |
| @@ -752,7 +752,7 @@ static int meson_spicc_probe(struct platform_device *pdev) |
| ret = meson_spicc_clk_init(spicc); |
| if (ret) { |
| dev_err(&pdev->dev, "clock registration failed\n"); |
| - goto out_master; |
| + goto out_clk; |
| } |
| |
| ret = devm_spi_register_master(&pdev->dev, master); |
| -- |
| 2.30.2 |
| |