| From 47ec636f7a25aa2549e198c48ecb6b1c25d05456 Mon Sep 17 00:00:00 2001 |
| From: Michael Buesch <m@bues.ch> |
| Date: Sat, 15 May 2021 21:02:52 +0200 |
| Subject: ssb: sdio: Don't overwrite const buffer if block_write fails |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Michael Buesch <m@bues.ch> |
| |
| commit 47ec636f7a25aa2549e198c48ecb6b1c25d05456 upstream. |
| |
| It doesn't make sense to clobber the const driver-side buffer, if a |
| write-to-device attempt failed. All other SSB variants (PCI, PCMCIA and SoC) |
| also don't corrupt the buffer on any failure in block_write. |
| Therefore, remove this memset from the SDIO variant. |
| |
| Signed-off-by: Michael Büsch <m@bues.ch> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Link: https://lore.kernel.org/r/20210515210252.318be2ba@wiggum |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/ssb/sdio.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/ssb/sdio.c |
| +++ b/drivers/ssb/sdio.c |
| @@ -411,7 +411,6 @@ static void ssb_sdio_block_write(struct |
| sdio_claim_host(bus->host_sdio); |
| if (unlikely(ssb_sdio_switch_core(bus, dev))) { |
| error = -EIO; |
| - memset((void *)buffer, 0xff, count); |
| goto err_out; |
| } |
| offset |= bus->sdio_sbaddr & 0xffff; |
