| From f52135a4de3a020b987d6483065b4443aa7dadac Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 22 Jul 2021 09:39:46 +0300 |
| Subject: sched/numa: Fix is_core_idle() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Mika Penttilä <mika.penttila@gmail.com> |
| |
| [ Upstream commit 1c6829cfd3d5124b125e6df41158665aea413b35 ] |
| |
| Use the loop variable instead of the function argument to test the |
| other SMT siblings for idle. |
| |
| Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks") |
| Signed-off-by: Mika Penttilä <mika.penttila@gmail.com> |
| Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> |
| Acked-by: Mel Gorman <mgorman@techsingularity.net> |
| Acked-by: Pankaj Gupta <pankaj.gupta@ionos.com> |
| Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| kernel/sched/fair.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c |
| index f60ef0b4ec33..3889fee98d11 100644 |
| --- a/kernel/sched/fair.c |
| +++ b/kernel/sched/fair.c |
| @@ -1529,7 +1529,7 @@ static inline bool is_core_idle(int cpu) |
| if (cpu == sibling) |
| continue; |
| |
| - if (!idle_cpu(cpu)) |
| + if (!idle_cpu(sibling)) |
| return false; |
| } |
| #endif |
| -- |
| 2.30.2 |
| |
