| From f0a28f4eca7b00bba8f0d3f5133d49abb0338d29 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 7 Sep 2021 20:00:23 -0700 |
| Subject: nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group |
| |
| From: Nanyong Sun <sunnanyong@huawei.com> |
| |
| [ Upstream commit 17243e1c3072b8417a5ebfc53065d0a87af7ca77 ] |
| |
| kobject_put() should be used to cleanup the memory associated with the |
| kobject instead of kobject_del(). See the section "Kobject removal" of |
| "Documentation/core-api/kobject.rst". |
| |
| Link: https://lkml.kernel.org/r/20210629022556.3985106-7-sunnanyong@huawei.com |
| Link: https://lkml.kernel.org/r/1625651306-10829-7-git-send-email-konishi.ryusuke@gmail.com |
| Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> |
| Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/nilfs2/sysfs.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c |
| index 5ba87573ad3b..62f8a7ac19c8 100644 |
| --- a/fs/nilfs2/sysfs.c |
| +++ b/fs/nilfs2/sysfs.c |
| @@ -202,7 +202,7 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root) |
| |
| void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root) |
| { |
| - kobject_del(&root->snapshot_kobj); |
| + kobject_put(&root->snapshot_kobj); |
| } |
| |
| /************************************************************************ |
| -- |
| 2.33.0 |
| |