| From 2a7d581279e33087b5883a10dff4ecf8f45b9d0e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 7 Jul 2021 18:27:53 +0200 |
| Subject: pwm: stm32-lp: Don't modify HW state in .remove() callback |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| |
| [ Upstream commit d44084c93427bb0a9261432db1a8ca76a42d805e ] |
| |
| A consumer is expected to disable a PWM before calling pwm_put(). And if |
| they didn't there is hopefully a good reason (or the consumer needs |
| fixing). Also if disabling an enabled PWM was the right thing to do, |
| this should better be done in the framework instead of in each low level |
| driver. |
| |
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Signed-off-by: Thierry Reding <thierry.reding@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pwm/pwm-stm32-lp.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c |
| index 93dd03618465..e4a10aac354d 100644 |
| --- a/drivers/pwm/pwm-stm32-lp.c |
| +++ b/drivers/pwm/pwm-stm32-lp.c |
| @@ -222,8 +222,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev) |
| { |
| struct stm32_pwm_lp *priv = platform_get_drvdata(pdev); |
| |
| - pwm_disable(&priv->chip.pwms[0]); |
| - |
| return pwmchip_remove(&priv->chip); |
| } |
| |
| -- |
| 2.33.0 |
| |
