| From 8a1e918d833ca5c391c4ded5dc006e2d1ce6d37c Mon Sep 17 00:00:00 2001 |
| From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> |
| Date: Fri, 26 Mar 2021 19:43:43 +0100 |
| Subject: i40e: Fix sparse warning: missing error code 'err' |
| |
| From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> |
| |
| commit 8a1e918d833ca5c391c4ded5dc006e2d1ce6d37c upstream. |
| |
| Set proper return values inside error checking if-statements. |
| |
| Previously following warning was produced when compiling against sparse. |
| i40e_main.c:15162 i40e_init_recovery_mode() warn: missing error code 'err' |
| |
| Fixes: 4ff0ee1af0169 ("i40e: Introduce recovery mode support") |
| Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> |
| Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> |
| Tested-by: Dave Switzer <david.switzer@intel.com> |
| Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++++-- |
| 1 file changed, 6 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/net/ethernet/intel/i40e/i40e_main.c |
| +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c |
| @@ -14701,12 +14701,16 @@ static int i40e_init_recovery_mode(struc |
| * in order to register the netdev |
| */ |
| v_idx = i40e_vsi_mem_alloc(pf, I40E_VSI_MAIN); |
| - if (v_idx < 0) |
| + if (v_idx < 0) { |
| + err = v_idx; |
| goto err_switch_setup; |
| + } |
| pf->lan_vsi = v_idx; |
| vsi = pf->vsi[v_idx]; |
| - if (!vsi) |
| + if (!vsi) { |
| + err = -EFAULT; |
| goto err_switch_setup; |
| + } |
| vsi->alloc_queue_pairs = 1; |
| err = i40e_config_netdev(vsi); |
| if (err) |
