| From foo@baz Sat 18 Apr 2020 11:09:57 AM CEST |
| From: Eran Ben Elisha <eranbe@mellanox.com> |
| Date: Tue, 24 Mar 2020 15:04:26 +0200 |
| Subject: net/mlx5e: Add missing release firmware call |
| |
| From: Eran Ben Elisha <eranbe@mellanox.com> |
| |
| [ Upstream commit d19987ccf57501894fdd8fadc2e55e4a3dd57239 ] |
| |
| Once driver finishes flashing the firmware image, it should release it. |
| |
| Fixes: 9c8bca2637b8 ("mlx5: Move firmware flash implementation to devlink") |
| Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com> |
| Reviewed-by: Aya Levin <ayal@mellanox.com> |
| Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c |
| @@ -23,7 +23,10 @@ static int mlx5_devlink_flash_update(str |
| if (err) |
| return err; |
| |
| - return mlx5_firmware_flash(dev, fw, extack); |
| + err = mlx5_firmware_flash(dev, fw, extack); |
| + release_firmware(fw); |
| + |
| + return err; |
| } |
| |
| static u8 mlx5_fw_ver_major(u32 version) |
