| From 1be19b7b9961c480186f2d80cfeb833f8a0e53c8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 13 Jun 2020 22:15:25 -0500 |
| Subject: usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work |
| |
| From: Aditya Pakki <pakki001@umn.edu> |
| |
| [ Upstream commit 2655971ad4b34e97dd921df16bb0b08db9449df7 ] |
| |
| dwc3_pci_resume_work() calls pm_runtime_get_sync() that increments |
| the reference counter. In case of failure, decrement the reference |
| before returning. |
| |
| Signed-off-by: Aditya Pakki <pakki001@umn.edu> |
| Signed-off-by: Felipe Balbi <balbi@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/dwc3/dwc3-pci.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c |
| index b67372737dc9b..96c05b121fac8 100644 |
| --- a/drivers/usb/dwc3/dwc3-pci.c |
| +++ b/drivers/usb/dwc3/dwc3-pci.c |
| @@ -206,8 +206,10 @@ static void dwc3_pci_resume_work(struct work_struct *work) |
| int ret; |
| |
| ret = pm_runtime_get_sync(&dwc3->dev); |
| - if (ret) |
| + if (ret) { |
| + pm_runtime_put_sync_autosuspend(&dwc3->dev); |
| return; |
| + } |
| |
| pm_runtime_mark_last_busy(&dwc3->dev); |
| pm_runtime_put_sync_autosuspend(&dwc3->dev); |
| -- |
| 2.25.1 |
| |
