| From a632c9da3e687fd23b2985b4115996ae2931e024 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 5 Jun 2020 20:59:14 +0200 |
| Subject: arm64: dts: qcom: msm8916: Replace invalid bias-pull-none property |
| |
| From: Stephan Gerhold <stephan@gerhold.net> |
| |
| [ Upstream commit 1b6a1a162defe649c5599d661b58ac64bb6f31b6 ] |
| |
| msm8916-pins.dtsi specifies "bias-pull-none" for most of the audio |
| pin configurations. This was likely copied from the qcom kernel fork |
| where the same property was used for these audio pins. |
| |
| However, "bias-pull-none" actually does not exist at all - not in |
| mainline and not in downstream. I can only guess that the original |
| intention was to configure "no pull", i.e. bias-disable. |
| |
| Change it to that instead. |
| |
| Fixes: 143bb9ad85b7 ("arm64: dts: qcom: add audio pinctrls") |
| Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
| Signed-off-by: Stephan Gerhold <stephan@gerhold.net> |
| Link: https://lore.kernel.org/r/20200605185916.318494-2-stephan@gerhold.net |
| Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 10 +++++----- |
| 1 file changed, 5 insertions(+), 5 deletions(-) |
| |
| diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi |
| index 242aaea688040..1235830ffd0b7 100644 |
| --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi |
| +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi |
| @@ -508,7 +508,7 @@ pinconf { |
| pins = "gpio63", "gpio64", "gpio65", "gpio66", |
| "gpio67", "gpio68"; |
| drive-strength = <8>; |
| - bias-pull-none; |
| + bias-disable; |
| }; |
| }; |
| cdc_pdm_lines_sus: pdm_lines_off { |
| @@ -537,7 +537,7 @@ pinconf { |
| pins = "gpio113", "gpio114", "gpio115", |
| "gpio116"; |
| drive-strength = <8>; |
| - bias-pull-none; |
| + bias-disable; |
| }; |
| }; |
| |
| @@ -565,7 +565,7 @@ pinmux { |
| pinconf { |
| pins = "gpio110"; |
| drive-strength = <8>; |
| - bias-pull-none; |
| + bias-disable; |
| }; |
| }; |
| |
| @@ -591,7 +591,7 @@ pinmux { |
| pinconf { |
| pins = "gpio116"; |
| drive-strength = <8>; |
| - bias-pull-none; |
| + bias-disable; |
| }; |
| }; |
| ext_mclk_tlmm_lines_sus: mclk_lines_off { |
| @@ -619,7 +619,7 @@ pinconf { |
| pins = "gpio112", "gpio117", "gpio118", |
| "gpio119"; |
| drive-strength = <8>; |
| - bias-pull-none; |
| + bias-disable; |
| }; |
| }; |
| ext_sec_tlmm_lines_sus: tlmm_lines_off { |
| -- |
| 2.25.1 |
| |