| From 768c9394abf741fd8db61641d00da91fab3563f4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 12 Jul 2020 08:24:53 -0700 |
| Subject: drm/bridge: sil_sii8620: initialize return of sii8620_readb |
| |
| From: Tom Rix <trix@redhat.com> |
| |
| [ Upstream commit 02cd2d3144653e6e2a0c7ccaa73311e48e2dc686 ] |
| |
| clang static analysis flags this error |
| |
| sil-sii8620.c:184:2: warning: Undefined or garbage value |
| returned to caller [core.uninitialized.UndefReturn] |
| return ret; |
| ^~~~~~~~~~ |
| |
| sii8620_readb calls sii8620_read_buf. |
| sii8620_read_buf can return without setting its output |
| pararmeter 'ret'. |
| |
| So initialize ret. |
| |
| Fixes: ce6e153f414a ("drm/bridge: add Silicon Image SiI8620 driver") |
| Signed-off-by: Tom Rix <trix@redhat.com> |
| Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> |
| Signed-off-by: Sam Ravnborg <sam@ravnborg.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20200712152453.27510-1-trix@redhat.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c |
| index 92acd336aa894..ca98133411aab 100644 |
| --- a/drivers/gpu/drm/bridge/sil-sii8620.c |
| +++ b/drivers/gpu/drm/bridge/sil-sii8620.c |
| @@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len) |
| |
| static u8 sii8620_readb(struct sii8620 *ctx, u16 addr) |
| { |
| - u8 ret; |
| + u8 ret = 0; |
| |
| sii8620_read_buf(ctx, addr, &ret, 1); |
| return ret; |
| -- |
| 2.25.1 |
| |