| From 27df4287ebe66e399a8c2ab831105645c0a3bc1e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 5 May 2020 17:03:29 +0100 |
| Subject: drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline |
| |
| From: Emil Velikov <emil.velikov@collabora.com> |
| |
| [ Upstream commit 7a05c3b6d24b8460b3cec436cf1d33fac43c8450 ] |
| |
| The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently |
| using the generic write. This does not look right. |
| |
| Perhaps some platforms don't distinguish between the two writers? |
| |
| Cc: Robert Chiras <robert.chiras@nxp.com> |
| Cc: Vinay Simha BN <simhavcs@gmail.com> |
| Cc: Jani Nikula <jani.nikula@intel.com> |
| Cc: Thierry Reding <treding@nvidia.com> |
| Fixes: e83950816367 ("drm/dsi: Implement set tear scanline") |
| Signed-off-by: Emil Velikov <emil.velikov@collabora.com> |
| Reviewed-by: Thierry Reding <treding@nvidia.com> |
| Signed-off-by: Sam Ravnborg <sam@ravnborg.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20200505160329.2976059-3-emil.l.velikov@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/drm_mipi_dsi.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c |
| index 55531895dde6d..37b03fefbdf6f 100644 |
| --- a/drivers/gpu/drm/drm_mipi_dsi.c |
| +++ b/drivers/gpu/drm/drm_mipi_dsi.c |
| @@ -1082,11 +1082,11 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); |
| */ |
| int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline) |
| { |
| - u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, scanline >> 8, |
| - scanline & 0xff }; |
| + u8 payload[2] = { scanline >> 8, scanline & 0xff }; |
| ssize_t err; |
| |
| - err = mipi_dsi_generic_write(dsi, payload, sizeof(payload)); |
| + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_TEAR_SCANLINE, payload, |
| + sizeof(payload)); |
| if (err < 0) |
| return err; |
| |
| -- |
| 2.25.1 |
| |