| From a203e708f767adb81c5069c7d551caa3fc0f93c4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 21 Jul 2020 13:34:07 -0700 |
| Subject: ionic: update eid test for overflow |
| |
| From: Shannon Nelson <snelson@pensando.io> |
| |
| [ Upstream commit 3fbc9bb6ca32d12d4d32a7ae32abef67ac95f889 ] |
| |
| Fix up our comparison to better handle a potential (but largely |
| unlikely) wrap around. |
| |
| Signed-off-by: Shannon Nelson <snelson@pensando.io> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c |
| index 337d971ffd92c..29f77faa808bb 100644 |
| --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c |
| +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c |
| @@ -709,7 +709,7 @@ static bool ionic_notifyq_service(struct ionic_cq *cq, |
| eid = le64_to_cpu(comp->event.eid); |
| |
| /* Have we run out of new completions to process? */ |
| - if (eid <= lif->last_eid) |
| + if ((s64)(eid - lif->last_eid) <= 0) |
| return false; |
| |
| lif->last_eid = eid; |
| -- |
| 2.25.1 |
| |
