| From 1e885f6ec3766168c1f0d8168e62422e89678871 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 19 Jun 2020 16:30:07 +0200 |
| Subject: media: allegro: Fix some NULL vs IS_ERR() checks in probe |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit d93d45ab716e4107056be54969c8c70e50a8346d ] |
| |
| The devm_ioremap() function doesn't return error pointers, it returns |
| NULL on error. |
| |
| Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/staging/media/allegro-dvt/allegro-core.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c |
| index 70f133a842ddf..3ed66aae741d5 100644 |
| --- a/drivers/staging/media/allegro-dvt/allegro-core.c |
| +++ b/drivers/staging/media/allegro-dvt/allegro-core.c |
| @@ -3065,9 +3065,9 @@ static int allegro_probe(struct platform_device *pdev) |
| return -EINVAL; |
| } |
| regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); |
| - if (IS_ERR(regs)) { |
| + if (!regs) { |
| dev_err(&pdev->dev, "failed to map registers\n"); |
| - return PTR_ERR(regs); |
| + return -ENOMEM; |
| } |
| dev->regmap = devm_regmap_init_mmio(&pdev->dev, regs, |
| &allegro_regmap_config); |
| @@ -3085,9 +3085,9 @@ static int allegro_probe(struct platform_device *pdev) |
| sram_regs = devm_ioremap(&pdev->dev, |
| sram_res->start, |
| resource_size(sram_res)); |
| - if (IS_ERR(sram_regs)) { |
| + if (!sram_regs) { |
| dev_err(&pdev->dev, "failed to map sram\n"); |
| - return PTR_ERR(sram_regs); |
| + return -ENOMEM; |
| } |
| dev->sram = devm_regmap_init_mmio(&pdev->dev, sram_regs, |
| &allegro_sram_config); |
| -- |
| 2.25.1 |
| |