| From fbe15e7910a69e56da46ce43c6042bab094aeb29 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 8 Jul 2020 03:16:48 +0800 |
| Subject: mt76: mt7615: fix potential memory leak in mcu message handler |
| |
| From: Sean Wang <sean.wang@mediatek.com> |
| |
| [ Upstream commit 9248c08c3fc4ef816c82aa49d01123f4746d349f ] |
| |
| Fix potential memory leak in mcu message handler on error condition. |
| |
| Fixes: 0e6a29e477f3 ("mt76: mt7615: add support to read temperature from mcu") |
| Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> |
| Signed-off-by: Sean Wang <sean.wang@mediatek.com> |
| Signed-off-by: Felix Fietkau <nbd@nbd.name> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c |
| index 29a7aaabb6da1..9c55424962522 100644 |
| --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c |
| +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c |
| @@ -167,8 +167,10 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd, |
| struct mt7615_mcu_rxd *rxd = (struct mt7615_mcu_rxd *)skb->data; |
| int ret = 0; |
| |
| - if (seq != rxd->seq) |
| - return -EAGAIN; |
| + if (seq != rxd->seq) { |
| + ret = -EAGAIN; |
| + goto out; |
| + } |
| |
| switch (cmd) { |
| case MCU_CMD_PATCH_SEM_CONTROL: |
| @@ -182,6 +184,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd, |
| default: |
| break; |
| } |
| +out: |
| dev_kfree_skb(skb); |
| |
| return ret; |
| -- |
| 2.25.1 |
| |
