| From 9c4baa99284a92f06b666fb4178d3edc6d6a8b47 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 2 Aug 2020 19:15:37 +0800 |
| Subject: net: ethernet: aquantia: Fix wrong return value |
| |
| From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> |
| |
| [ Upstream commit 0470a48880f8bc42ce26962b79c7b802c5a695ec ] |
| |
| In function hw_atl_a0_hw_multicast_list_set(), when an invalid |
| request is encountered, a negative error code should be returned. |
| |
| Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions") |
| Cc: David VomLehn <vomlehn@texas.net> |
| Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c |
| index 9b1062b8af640..1e8b778cb9fa2 100644 |
| --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c |
| +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c |
| @@ -782,7 +782,7 @@ static int hw_atl_a0_hw_multicast_list_set(struct aq_hw_s *self, |
| int err = 0; |
| |
| if (count > (HW_ATL_A0_MAC_MAX - HW_ATL_A0_MAC_MIN)) { |
| - err = EBADRQC; |
| + err = -EBADRQC; |
| goto err_exit; |
| } |
| for (self->aq_nic_cfg->mc_list_count = 0U; |
| -- |
| 2.25.1 |
| |
