| From c086cb1961395e0e23875a71f7717943f4d2c528 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 10 Jul 2020 17:30:17 +0800 |
| Subject: platform/x86: intel-hid: Fix return value check in check_acpi_dev() |
| |
| From: Lu Wei <luwei32@huawei.com> |
| |
| [ Upstream commit 71fbe886ce6dd0be17f20aded9c63fe58edd2806 ] |
| |
| In the function check_acpi_dev(), if it fails to create |
| platform device, the return value is ERR_PTR() or NULL. |
| Thus it must use IS_ERR_OR_NULL() to check return value. |
| |
| Fixes: ecc83e52b28c ("intel-hid: new hid event driver for hotkeys") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Lu Wei <luwei32@huawei.com> |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/platform/x86/intel-hid.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c |
| index 9ee79b74311c1..86261970bd8f3 100644 |
| --- a/drivers/platform/x86/intel-hid.c |
| +++ b/drivers/platform/x86/intel-hid.c |
| @@ -571,7 +571,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv) |
| return AE_OK; |
| |
| if (acpi_match_device_ids(dev, ids) == 0) |
| - if (acpi_create_platform_device(dev, NULL)) |
| + if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL))) |
| dev_info(&dev->dev, |
| "intel-hid: created platform device\n"); |
| |
| -- |
| 2.25.1 |
| |
