| From 77c99f6c6998ccd3ac8ac2da70202fc20e84ca81 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 2 Aug 2020 19:15:40 +0800 |
| Subject: tools, bpftool: Fix wrong return value in do_dump() |
| |
| From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> |
| |
| [ Upstream commit 041549b7b2c7811ec40e705c439211f00ade2dda ] |
| |
| In case of btf_id does not exist, a negative error code -ENOENT |
| should be returned. |
| |
| Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") |
| Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> |
| Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> |
| Reviewed-by: Tobias Klauser <tklauser@distanz.ch> |
| Acked-by: Andrii Nakryiko <andriin@fb.com> |
| Acked-by: John Fastabend <john.fastabend@gmail.com> |
| Link: https://lore.kernel.org/bpf/20200802111540.5384-1-tianjia.zhang@linux.alibaba.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/bpf/bpftool/btf.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c |
| index bcaf55b594982..81a77475bea61 100644 |
| --- a/tools/bpf/bpftool/btf.c |
| +++ b/tools/bpf/bpftool/btf.c |
| @@ -597,7 +597,7 @@ static int do_dump(int argc, char **argv) |
| goto done; |
| } |
| if (!btf) { |
| - err = ENOENT; |
| + err = -ENOENT; |
| p_err("can't find btf with ID (%u)", btf_id); |
| goto done; |
| } |
| -- |
| 2.25.1 |
| |
