| From 8c41a9aaacffde8bf2b20399435c4d1954857618 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 23 Apr 2020 00:07:19 +0800 |
| Subject: video: fbdev: sm712fb: fix an issue about iounmap for a wrong address |
| |
| From: Dejin Zheng <zhengdejin5@gmail.com> |
| |
| [ Upstream commit 98bd4f72988646c35569e1e838c0ab80d06c77f6 ] |
| |
| the sfb->fb->screen_base is not save the value get by iounmap() when |
| the chip id is 0x720. so iounmap() for address sfb->fb->screen_base |
| is not right. |
| |
| Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") |
| Cc: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Cc: Teddy Wang <teddy.wang@siliconmotion.com> |
| Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> |
| Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20200422160719.27763-1-zhengdejin5@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/sm712fb.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c |
| index 6a1b4a853d9ee..8cd655d6d6280 100644 |
| --- a/drivers/video/fbdev/sm712fb.c |
| +++ b/drivers/video/fbdev/sm712fb.c |
| @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb, |
| static void smtc_unmap_smem(struct smtcfb_info *sfb) |
| { |
| if (sfb && sfb->fb->screen_base) { |
| + if (sfb->chip_id == 0x720) |
| + sfb->fb->screen_base -= 0x00200000; |
| iounmap(sfb->fb->screen_base); |
| sfb->fb->screen_base = NULL; |
| } |
| -- |
| 2.25.1 |
| |