| From 1a8cfa24e21c2f154791f0cdd85fc28496918722 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Mon, 26 Oct 2020 22:51:57 +0100 |
| Subject: perf/x86/intel/uncore: Fix Add BW copypasta |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit 1a8cfa24e21c2f154791f0cdd85fc28496918722 upstream. |
| |
| gcc -Wextra points out a duplicate initialization of one array |
| member: |
| |
| arch/x86/events/intel/uncore_snb.c:478:37: warning: initialized field overwritten [-Woverride-init] |
| 478 | [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE, |
| |
| The only sensible explanation is that a duplicate 'READS' was used |
| instead of the correct 'WRITES', so change it back. |
| |
| Fixes: 24633d901ea4 ("perf/x86/intel/uncore: Add BW counters for GT, IA and IO breakdown") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> |
| Link: https://lkml.kernel.org/r/20201026215203.3893972-1-arnd@kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/x86/events/intel/uncore_snb.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/arch/x86/events/intel/uncore_snb.c |
| +++ b/arch/x86/events/intel/uncore_snb.c |
| @@ -459,7 +459,7 @@ enum perf_snb_uncore_imc_freerunning_typ |
| static struct freerunning_counters snb_uncore_imc_freerunning[] = { |
| [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_READS_BASE, |
| 0x0, 0x0, 1, 32 }, |
| - [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE, |
| + [SNB_PCI_UNCORE_IMC_DATA_WRITES] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE, |
| 0x0, 0x0, 1, 32 }, |
| [SNB_PCI_UNCORE_IMC_GT_REQUESTS] = { SNB_UNCORE_PCI_IMC_GT_REQUESTS_BASE, |
| 0x0, 0x0, 1, 32 }, |
