| From dd1af128b7823d7f3263b1eda488d10fb11cd871 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 12 Mar 2021 15:25:21 -0500 |
| Subject: btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s |
| |
| From: Josef Bacik <josef@toxicpanda.com> |
| |
| [ Upstream commit 7a9213a93546e7eaef90e6e153af6b8fc7553f10 ] |
| |
| A few BUG_ON()'s in replace_path are purely to keep us from making |
| logical mistakes, so replace them with ASSERT()'s. |
| |
| Reviewed-by: Qu Wenruo <wqu@suse.com> |
| Signed-off-by: Josef Bacik <josef@toxicpanda.com> |
| Reviewed-by: David Sterba <dsterba@suse.com> |
| Signed-off-by: David Sterba <dsterba@suse.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/btrfs/relocation.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c |
| index c01239d1f1e6..313547442a6e 100644 |
| --- a/fs/btrfs/relocation.c |
| +++ b/fs/btrfs/relocation.c |
| @@ -1808,8 +1808,8 @@ int replace_path(struct btrfs_trans_handle *trans, |
| int ret; |
| int slot; |
| |
| - BUG_ON(src->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID); |
| - BUG_ON(dest->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID); |
| + ASSERT(src->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID); |
| + ASSERT(dest->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID); |
| |
| last_snapshot = btrfs_root_last_snapshot(&src->root_item); |
| again: |
| @@ -1841,7 +1841,7 @@ again: |
| parent = eb; |
| while (1) { |
| level = btrfs_header_level(parent); |
| - BUG_ON(level < lowest_level); |
| + ASSERT(level >= lowest_level); |
| |
| ret = btrfs_bin_search(parent, &key, level, &slot); |
| if (ret && slot > 0) |
| -- |
| 2.30.2 |
| |