| From f88f1466e2a2e5ca17dfada436d3efa1b03a3972 Mon Sep 17 00:00:00 2001 |
| From: Fengnan Chang <changfengnan@vivo.com> |
| Date: Fri, 2 Apr 2021 18:16:31 +0800 |
| Subject: ext4: fix error code in ext4_commit_super |
| |
| From: Fengnan Chang <changfengnan@vivo.com> |
| |
| commit f88f1466e2a2e5ca17dfada436d3efa1b03a3972 upstream. |
| |
| We should set the error code when ext4_commit_super check argument failed. |
| Found in code review. |
| Fixes: c4be0c1dc4cdc ("filesystem freeze: add error handling of write_super_lockfs/unlockfs"). |
| |
| Cc: stable@kernel.org |
| Signed-off-by: Fengnan Chang <changfengnan@vivo.com> |
| Reviewed-by: Andreas Dilger <adilger@dilger.ca> |
| Link: https://lore.kernel.org/r/20210402101631.561-1-changfengnan@vivo.com |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/ext4/super.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| --- a/fs/ext4/super.c |
| +++ b/fs/ext4/super.c |
| @@ -4859,8 +4859,10 @@ static int ext4_commit_super(struct supe |
| struct buffer_head *sbh = EXT4_SB(sb)->s_sbh; |
| int error = 0; |
| |
| - if (!sbh || block_device_ejected(sb)) |
| - return error; |
| + if (!sbh) |
| + return -EINVAL; |
| + if (block_device_ejected(sb)) |
| + return -ENODEV; |
| |
| /* |
| * If the file system is mounted read-only, don't update the |
