| From 4b793acdca0050739b99ace6a8b9e7f717f57c6b Mon Sep 17 00:00:00 2001 |
| From: Taehee Yoo <ap420073@gmail.com> |
| Date: Fri, 28 Feb 2020 18:01:46 +0000 |
| Subject: hsr: use netdev_err() instead of WARN_ONCE() |
| |
| From: Taehee Yoo <ap420073@gmail.com> |
| |
| commit 4b793acdca0050739b99ace6a8b9e7f717f57c6b upstream. |
| |
| When HSR interface is sending a frame, it finds a node with |
| the destination ethernet address from the list. |
| If there is no node, it calls WARN_ONCE(). |
| But, using WARN_ONCE() for this situation is a little bit overdoing. |
| So, in this patch, the netdev_err() is used instead. |
| |
| Signed-off-by: Taehee Yoo <ap420073@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Cc: George Kennedy <george.kennedy@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/hsr/hsr_framereg.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/net/hsr/hsr_framereg.c |
| +++ b/net/hsr/hsr_framereg.c |
| @@ -310,7 +310,8 @@ void hsr_addr_subst_dest(struct hsr_node |
| |
| node_dst = find_node_by_AddrA(&port->hsr->node_db, eth_hdr(skb)->h_dest); |
| if (!node_dst) { |
| - WARN_ONCE(1, "%s: Unknown node\n", __func__); |
| + if (net_ratelimit()) |
| + netdev_err(skb->dev, "%s: Unknown node\n", __func__); |
| return; |
| } |
| if (port->type != node_dst->AddrB_port) |