| From d418ff56b8f2d2b296daafa8da151fe27689b757 Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Mon, 19 Mar 2018 16:34:00 +0100 |
| Subject: libata: Modify quirks for MX100 to limit NCQ_TRIM quirk to MU01 version |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| commit d418ff56b8f2d2b296daafa8da151fe27689b757 upstream. |
| |
| When commit 9c7be59fc519af ("libata: Apply NOLPM quirk to Crucial MX100 |
| 512GB SSDs") was added it inherited the ATA_HORKAGE_NO_NCQ_TRIM quirk |
| from the existing "Crucial_CT*MX100*" entry, but that entry sets model_rev |
| to "MU01", where as the entry adding the NOLPM quirk sets it to NULL. |
| |
| This means that after this commit we no apply the NO_NCQ_TRIM quirk to |
| all "Crucial_CT512MX100*" SSDs even if they have the fixed "MU02" |
| firmware. This commit splits the "Crucial_CT512MX100*" quirk into 2 |
| quirks, one for the "MU01" firmware and one for all other firmware |
| versions, so that we once again only apply the NO_NCQ_TRIM quirk to the |
| "MU01" firmware version. |
| |
| Fixes: 9c7be59fc519af ("libata: Apply NOLPM quirk to ... MX100 512GB SSDs") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Tejun Heo <tj@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/ata/libata-core.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/ata/libata-core.c |
| +++ b/drivers/ata/libata-core.c |
| @@ -4406,10 +4406,13 @@ static const struct ata_blacklist_entry |
| /* Crucial BX100 SSD 500GB has broken LPM support */ |
| { "CT500BX100SSD1", NULL, ATA_HORKAGE_NOLPM }, |
| |
| - /* The 512GB version of the MX100 has both queued TRIM and LPM issues */ |
| - { "Crucial_CT512MX100*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | |
| + /* 512GB MX100 with MU01 firmware has both queued TRIM and LPM issues */ |
| + { "Crucial_CT512MX100*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM | |
| ATA_HORKAGE_ZERO_AFTER_TRIM | |
| ATA_HORKAGE_NOLPM, }, |
| + /* 512GB MX100 with newer firmware has only LPM issues */ |
| + { "Crucial_CT512MX100*", NULL, ATA_HORKAGE_ZERO_AFTER_TRIM | |
| + ATA_HORKAGE_NOLPM, }, |
| |
| /* 480GB+ M500 SSDs have both queued TRIM and LPM issues */ |
| { "Crucial_CT480M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | |
