| From fafdf5f8f12c68e8a59dfab34d96756a5eb7c0e3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 25 Jan 2026 22:44:52 +0800 |
| Subject: PCI/MSI: Unmap MSI-X region on error |
| |
| From: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn> |
| |
| [ Upstream commit 1a8d4c6ecb4c81261bcdf13556abd4a958eca202 ] |
| |
| msix_capability_init() fails to unmap the MSI-X region if |
| msix_setup_interrupts() fails. |
| |
| Add the missing iounmap() for that error path. |
| |
| [ tglx: Massaged change log ] |
| |
| Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn> |
| Signed-off-by: Thomas Gleixner <tglx@kernel.org> |
| Link: https://patch.msgid.link/20260125144452.2103812-1-lihaoxiang@isrc.iscas.ac.cn |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pci/msi/msi.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c |
| index 7110aed956c75..7a2375585338b 100644 |
| --- a/drivers/pci/msi/msi.c |
| +++ b/drivers/pci/msi/msi.c |
| @@ -648,7 +648,7 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries, |
| |
| ret = msix_setup_interrupts(dev, base, entries, nvec, affd); |
| if (ret) |
| - goto out_disable; |
| + goto out_unmap; |
| |
| /* Disable INTX */ |
| pci_intx_for_msi(dev, 0); |
| @@ -667,6 +667,8 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries, |
| pcibios_free_irq(dev); |
| return 0; |
| |
| +out_unmap: |
| + iounmap(dev->msix_base); |
| out_disable: |
| dev->msix_enabled = 0; |
| pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL | PCI_MSIX_FLAGS_ENABLE, 0); |
| -- |
| 2.51.0 |
| |