| From 8d81fe3818a1e1b4c97628a09627415e1567ecdd Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 13 Jan 2026 17:41:34 +0800 |
| Subject: ipmi: ipmb: initialise event handler read bytes |
| |
| From: Matt Johnston <matt@codeconstruct.com.au> |
| |
| [ Upstream commit 9f235ccecd03c436cb1683eac16b12f119e54aa9 ] |
| |
| IPMB doesn't use i2c reads, but the handler needs to set a value. |
| Otherwise an i2c read will return an uninitialised value from the bus |
| driver. |
| |
| Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB") |
| Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> |
| Message-ID: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au> |
| Signed-off-by: Corey Minyard <corey@minyard.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/char/ipmi/ipmi_ipmb.c | 5 +++++ |
| 1 file changed, 5 insertions(+) |
| |
| diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c |
| index 6a4f279c7c1f5..163ec867d68af 100644 |
| --- a/drivers/char/ipmi/ipmi_ipmb.c |
| +++ b/drivers/char/ipmi/ipmi_ipmb.c |
| @@ -202,11 +202,16 @@ static int ipmi_ipmb_slave_cb(struct i2c_client *client, |
| break; |
| |
| case I2C_SLAVE_READ_REQUESTED: |
| + *val = 0xff; |
| + ipmi_ipmb_check_msg_done(iidev); |
| + break; |
| + |
| case I2C_SLAVE_STOP: |
| ipmi_ipmb_check_msg_done(iidev); |
| break; |
| |
| case I2C_SLAVE_READ_PROCESSED: |
| + *val = 0xff; |
| break; |
| } |
| |
| -- |
| 2.51.0 |
| |