| From 9c08731b70912e342f6f6c86cc3911b4dc8cba8a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 4 Jan 2026 14:40:54 +0800 |
| Subject: RDMA/hns: Fix WQ_MEM_RECLAIM warning |
| |
| From: Chengchang Tang <tangchengchang@huawei.com> |
| |
| [ Upstream commit c0a26bbd3f99b7b03f072e3409aff4e6ec8af6f6 ] |
| |
| When sunrpc is used, if a reset triggered, our wq may lead the |
| following trace: |
| |
| workqueue: WQ_MEM_RECLAIM xprtiod:xprt_rdma_connect_worker [rpcrdma] |
| is flushing !WQ_MEM_RECLAIM hns_roce_irq_workq:flush_work_handle |
| [hns_roce_hw_v2] |
| WARNING: CPU: 0 PID: 8250 at kernel/workqueue.c:2644 check_flush_dependency+0xe0/0x144 |
| Call trace: |
| check_flush_dependency+0xe0/0x144 |
| start_flush_work.constprop.0+0x1d0/0x2f0 |
| __flush_work.isra.0+0x40/0xb0 |
| flush_work+0x14/0x30 |
| hns_roce_v2_destroy_qp+0xac/0x1e0 [hns_roce_hw_v2] |
| ib_destroy_qp_user+0x9c/0x2b4 |
| rdma_destroy_qp+0x34/0xb0 |
| rpcrdma_ep_destroy+0x28/0xcc [rpcrdma] |
| rpcrdma_ep_put+0x74/0xb4 [rpcrdma] |
| rpcrdma_xprt_disconnect+0x1d8/0x260 [rpcrdma] |
| xprt_rdma_connect_worker+0xc0/0x120 [rpcrdma] |
| process_one_work+0x1cc/0x4d0 |
| worker_thread+0x154/0x414 |
| kthread+0x104/0x144 |
| ret_from_fork+0x10/0x18 |
| |
| Since QP destruction frees memory, this wq should have the WQ_MEM_RECLAIM. |
| |
| Fixes: ffd541d45726 ("RDMA/hns: Add the workqueue framework for flush cqe handler") |
| Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> |
| Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> |
| Link: https://patch.msgid.link/20260104064057.1582216-2-huangjunxian6@hisilicon.com |
| Signed-off-by: Leon Romanovsky <leon@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c |
| index f1d4494c7d008..2d4b751fc709d 100644 |
| --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c |
| +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c |
| @@ -6604,7 +6604,8 @@ static int hns_roce_v2_init_eq_table(struct hns_roce_dev *hr_dev) |
| |
| INIT_WORK(&hr_dev->ecc_work, fmea_ram_ecc_work); |
| |
| - hr_dev->irq_workq = alloc_ordered_workqueue("hns_roce_irq_workq", 0); |
| + hr_dev->irq_workq = alloc_ordered_workqueue("hns_roce_irq_workq", |
| + WQ_MEM_RECLAIM); |
| if (!hr_dev->irq_workq) { |
| dev_err(dev, "failed to create irq workqueue.\n"); |
| ret = -ENOMEM; |
| -- |
| 2.51.0 |
| |