| From 1ff4dbbc292c4fa7e2a46aac313728197966814c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 30 Jan 2026 10:14:12 -0700 |
| Subject: ublk: Validate SQE128 flag before accessing the cmd |
| |
| From: Govindarajulu Varadarajan <govind.varadar@gmail.com> |
| |
| [ Upstream commit da7e4b75e50c087d2031a92f6646eb90f7045a67 ] |
| |
| ublk_ctrl_cmd_dump() accesses (header *)sqe->cmd before |
| IO_URING_F_SQE128 flag check. This could cause out of boundary memory |
| access. |
| |
| Move the SQE128 flag check earlier in ublk_ctrl_uring_cmd() to return |
| -EINVAL immediately if the flag is not set. |
| |
| Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") |
| Signed-off-by: Govindarajulu Varadarajan <govind.varadar@gmail.com> |
| Reviewed-by: Caleb Sander Mateos <csander@purestorage.com> |
| Reviewed-by: Ming Lei <ming.lei@redhat.com> |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/block/ublk_drv.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c |
| index 3a7c42f76d894..121b62f8bb0a2 100644 |
| --- a/drivers/block/ublk_drv.c |
| +++ b/drivers/block/ublk_drv.c |
| @@ -2010,10 +2010,10 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd, |
| if (issue_flags & IO_URING_F_NONBLOCK) |
| return -EAGAIN; |
| |
| - ublk_ctrl_cmd_dump(cmd); |
| - |
| if (!(issue_flags & IO_URING_F_SQE128)) |
| - goto out; |
| + return -EINVAL; |
| + |
| + ublk_ctrl_cmd_dump(cmd); |
| |
| ret = -EPERM; |
| if (!capable(CAP_SYS_ADMIN)) |
| -- |
| 2.51.0 |
| |
