| From 6b99eeacf6abb1ff2d6463c84e490343f39cf11a Mon Sep 17 00:00:00 2001 |
| From: Abel Vesa <abel.vesa@linaro.org> |
| Date: Wed, 24 Dec 2025 12:53:27 +0200 |
| Subject: dt-bindings: phy: qcom-edp: Add missing clock for X Elite |
| |
| From: Abel Vesa <abel.vesa@linaro.org> |
| |
| commit 6b99eeacf6abb1ff2d6463c84e490343f39cf11a upstream. |
| |
| On X Elite platform, the eDP PHY uses one more clock called ref. |
| |
| The current X Elite devices supported upstream work fine without this |
| clock, because the boot firmware leaves this clock enabled. But we should |
| not rely on that. Also, even though this change breaks the ABI, it is |
| needed in order to make the driver disables this clock along with the |
| other ones, for a proper bring-down of the entire PHY. |
| |
| So attach the this ref clock to the PHY. |
| |
| Cc: stable@vger.kernel.org # v6.10 |
| Fixes: 5d5607861350 ("dt-bindings: phy: qcom-edp: Add X1E80100 PHY compatibles") |
| Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| Reviewed-by: Bjorn Andersson <andersson@kernel.org> |
| Signed-off-by: Abel Vesa <abel.vesa@linaro.org> |
| Link: https://patch.msgid.link/20251224-phy-qcom-edp-add-missing-refclk-v5-1-3f45d349b5ac@oss.qualcomm.com |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 28 +++++++++++++++- |
| 1 file changed, 27 insertions(+), 1 deletion(-) |
| |
| --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml |
| +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml |
| @@ -31,12 +31,15 @@ properties: |
| - description: PLL register block |
| |
| clocks: |
| - maxItems: 2 |
| + minItems: 2 |
| + maxItems: 3 |
| |
| clock-names: |
| + minItems: 2 |
| items: |
| - const: aux |
| - const: cfg_ahb |
| + - const: ref |
| |
| "#clock-cells": |
| const: 1 |
| @@ -58,6 +61,29 @@ required: |
| - "#clock-cells" |
| - "#phy-cells" |
| |
| +allOf: |
| + - if: |
| + properties: |
| + compatible: |
| + enum: |
| + - qcom,x1e80100-dp-phy |
| + then: |
| + properties: |
| + clocks: |
| + minItems: 3 |
| + maxItems: 3 |
| + clock-names: |
| + minItems: 3 |
| + maxItems: 3 |
| + else: |
| + properties: |
| + clocks: |
| + minItems: 2 |
| + maxItems: 2 |
| + clock-names: |
| + minItems: 2 |
| + maxItems: 2 |
| + |
| additionalProperties: false |
| |
| examples: |