| From 42b9c0795c00d28515b3e2525c76128db960908c Mon Sep 17 00:00:00 2001 | |
| From: Sasha Levin <sashal@kernel.org> | |
| Date: Mon, 15 Jun 2026 18:57:29 -0400 | |
| Subject: drm/amdgpu/atomfirmware: WARN() rather than BUG() | |
| From: Alex Deucher <alexander.deucher@amd.com> | |
| [ Upstream commit d7c595044965c826e6f3ce30590d3ec4399cd633 ] | |
| There's no need to crash the kernel for this case. Just | |
| return an error. | |
| Reviewed-by: Kent Russell <kent.russell@amd.com> | |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> | |
| Signed-off-by: Sasha Levin <sashal@kernel.org> | |
| --- | |
| drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 2 -- | |
| 1 file changed, 2 deletions(-) | |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | |
| index 6521d06c7e4e7..2b65c7bbb57c8 100644 | |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | |
| @@ -763,8 +763,6 @@ int amdgpu_atomfirmware_get_clock_info(struct amdgpu_device *adev) | |
| (crev != 6)) { | |
| spll->reference_freq = le32_to_cpu(gfx_info->v22.rlc_gpu_timer_refclk); | |
| ret = 0; | |
| - } else { | |
| - BUG(); | |
| } | |
| } | |
| } | |
| -- | |
| 2.53.0 | |