| From af8917280a5bb0d1f3eb76a047c1e2c1f30e7619 Mon Sep 17 00:00:00 2001 | |
| From: Sasha Levin <sashal@kernel.org> | |
| Date: Wed, 8 Jul 2026 22:21:25 +0900 | |
| Subject: ksmbd: allow FSCTL_SET_SPARSE without input buffer | |
| From: Namjae Jeon <linkinjeon@kernel.org> | |
| [ Upstream commit 86c84cc760080929b7be44bceebe5854957b99da ] | |
| FSCTL_SET_SPARSE without an input buffer sets a file sparse. Treat a | |
| zero-length input buffer as SetSparse=true and keep rejecting truncated | |
| non-empty buffers. | |
| Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> | |
| Signed-off-by: Sasha Levin <sashal@kernel.org> | |
| --- | |
| fs/smb/server/smb2pdu.c | 10 ++++++++-- | |
| 1 file changed, 8 insertions(+), 2 deletions(-) | |
| diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c | |
| index 07cd069d2ec47..60d13595025d1 100644 | |
| --- a/fs/smb/server/smb2pdu.c | |
| +++ b/fs/smb/server/smb2pdu.c | |
| @@ -8548,15 +8548,21 @@ int smb2_ioctl(struct ksmbd_work *work) | |
| rsp); | |
| break; | |
| case FSCTL_SET_SPARSE: | |
| - if (in_buf_len < sizeof(struct file_sparse)) { | |
| + { | |
| + struct file_sparse sparse = {0}; | |
| + | |
| + if (in_buf_len && in_buf_len < sizeof(struct file_sparse)) { | |
| ret = -EINVAL; | |
| goto out; | |
| } | |
| - ret = fsctl_set_sparse(work, id, (struct file_sparse *)buffer); | |
| + *(u8 *)&sparse = 1; | |
| + ret = fsctl_set_sparse(work, id, in_buf_len ? | |
| + (struct file_sparse *)buffer : &sparse); | |
| if (ret < 0) | |
| goto out; | |
| break; | |
| + } | |
| case FSCTL_SET_ZERO_DATA: | |
| { | |
| struct file_zero_data_information *zero_data; | |
| -- | |
| 2.53.0 | |