| From e8e6d37e73e6b950c891c780745460b87f4755b6 Mon Sep 17 00:00:00 2001 |
| From: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Date: Mon, 10 Aug 2015 16:53:54 -0300 |
| Subject: perf hists: Update the column width for the "srcline" sort key |
| |
| From: Arnaldo Carvalho de Melo <acme@redhat.com> |
| |
| commit e8e6d37e73e6b950c891c780745460b87f4755b6 upstream. |
| |
| When we introduce a new sort key, we need to update the |
| hists__calc_col_len() function accordingly, otherwise the width |
| will be limited to strlen(header). |
| |
| We can't update it when obtaining a line value for a column (for |
| instance, in sort__srcline_cmp()), because we reset it all when doing a |
| resort (see hists__output_recalc_col_len()), so we need to, from what is |
| in the hist_entry fields, set each of the column widths. |
| |
| Cc: Namhyung Kim <namhyung@kernel.org> |
| Cc: Andi Kleen <andi@firstfloor.org> |
| Cc: Jiri Olsa <jolsa@kernel.org> |
| Fixes: 409a8be61560 ("perf tools: Add sort by src line/number") |
| Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| tools/perf/util/hist.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/tools/perf/util/hist.c |
| +++ b/tools/perf/util/hist.c |
| @@ -160,6 +160,9 @@ void hists__calc_col_len(struct hists *h |
| hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12); |
| hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12); |
| |
| + if (h->srcline) |
| + hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline)); |
| + |
| if (h->transaction) |
| hists__new_col_len(hists, HISTC_TRANSACTION, |
| hist_entry__transaction_len()); |