| From 7a7f84ccb82e542c845c43f604665ccea1247866 Mon Sep 17 00:00:00 2001 |
| From: Ville Syrjälä <ville.syrjala@linux.intel.com> |
| Date: Thu, 16 Oct 2014 20:46:10 +0300 |
| Subject: drm/i915: Ignore long hpds on eDP ports |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Ville Syrjälä <ville.syrjala@linux.intel.com> |
| |
| original upstream id: 7a7f84ccb82e542c845c43f604665ccea1247866 |
| |
| Turning vdd on/off can generate a long hpd pulse on eDP ports. In order |
| to handle hpd we would need to turn on vdd to perform aux transfers. |
| This would lead to an endless cycle of |
| "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." |
| |
| So ignore long hpd pulses on eDP ports. eDP panels should be physically |
| tied to the machine anyway so they should not actually disappear and |
| thus don't need long hpd handling. Short hpds are still needed for link |
| re-train and whatnot so we can't just turn off the hpd interrupt |
| entirely for eDP ports. Perhaps we could turn it off whenever the panel |
| is disabled, but just ignoring the long hpd seems sufficient. |
| |
| Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> |
| Reviewed-by: Dave Airlie <airlied@redhat.com> |
| Reviewed-by: Todd Previte <tprevite@gmail.com> |
| Signed-off-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/i915/intel_dp.c | 12 ++++++++++++ |
| 1 file changed, 12 insertions(+) |
| |
| --- a/drivers/gpu/drm/i915/intel_dp.c |
| +++ b/drivers/gpu/drm/i915/intel_dp.c |
| @@ -4084,6 +4084,18 @@ intel_dp_hpd_pulse(struct intel_digital_ |
| if (intel_dig_port->base.type != INTEL_OUTPUT_EDP) |
| intel_dig_port->base.type = INTEL_OUTPUT_DISPLAYPORT; |
| |
| + if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { |
| + /* |
| + * vdd off can generate a long pulse on eDP which |
| + * would require vdd on to handle it, and thus we |
| + * would end up in an endless cycle of |
| + * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." |
| + */ |
| + DRM_DEBUG_KMS("ignoring long hpd on eDP port %c\n", |
| + port_name(intel_dig_port->port)); |
| + return false; |
| + } |
| + |
| DRM_DEBUG_KMS("got hpd irq on port %d - %s\n", intel_dig_port->port, |
| long_hpd ? "long" : "short"); |
| |