| From 2d970747ff883167efb28f6368e503493bb4a5e3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 7 Sep 2021 20:00:18 -0700 |
| Subject: nilfs2: fix memory leak in nilfs_sysfs_delete_##name##_group |
| |
| From: Nanyong Sun <sunnanyong@huawei.com> |
| |
| [ Upstream commit a3e181259ddd61fd378390977a1e4e2316853afa ] |
| |
| The kobject_put() should be used to cleanup the memory associated with the |
| kobject instead of kobject_del. See the section "Kobject removal" of |
| "Documentation/core-api/kobject.rst". |
| |
| Link: https://lkml.kernel.org/r/20210629022556.3985106-5-sunnanyong@huawei.com |
| Link: https://lkml.kernel.org/r/1625651306-10829-5-git-send-email-konishi.ryusuke@gmail.com |
| Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> |
| Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/nilfs2/sysfs.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c |
| index 31d640a87b59..195f42192a15 100644 |
| --- a/fs/nilfs2/sysfs.c |
| +++ b/fs/nilfs2/sysfs.c |
| @@ -97,7 +97,7 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \ |
| } \ |
| static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \ |
| { \ |
| - kobject_del(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \ |
| + kobject_put(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \ |
| } |
| |
| /************************************************************************ |
| -- |
| 2.33.0 |
| |