| From 667e9334fa64da2273e36ce131b05ac9e47c5769 Mon Sep 17 00:00:00 2001 |
| From: b-ak <anur.bhargav@gmail.com> |
| Date: Mon, 7 Jan 2019 22:30:22 +0530 |
| Subject: ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode |
| |
| From: b-ak <anur.bhargav@gmail.com> |
| |
| commit 667e9334fa64da2273e36ce131b05ac9e47c5769 upstream. |
| |
| During the bootup of the kernel, the DAPM bias level is in the OFF |
| state. As soon as the DAPM framework kicks in it pushes the codec |
| into STANDBY state. |
| |
| The probe function doesn't prepare the clock, and STANDBY state |
| does a clk_disable_unprepare() without checking the previous state. |
| This leads to an OOPS. |
| |
| Not transitioning from an OFF state to the STANDBY state fixes the |
| problem. |
| |
| Signed-off-by: b-ak <anur.bhargav@gmail.com> |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/soc/codecs/tlv320aic32x4.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/sound/soc/codecs/tlv320aic32x4.c |
| +++ b/sound/soc/codecs/tlv320aic32x4.c |
| @@ -822,6 +822,10 @@ static int aic32x4_set_bias_level(struct |
| case SND_SOC_BIAS_PREPARE: |
| break; |
| case SND_SOC_BIAS_STANDBY: |
| + /* Initial cold start */ |
| + if (snd_soc_component_get_bias_level(component) == SND_SOC_BIAS_OFF) |
| + break; |
| + |
| /* Switch off BCLK_N Divider */ |
| snd_soc_component_update_bits(component, AIC32X4_BCLKN, |
| AIC32X4_BCLKEN, 0); |
