| From 3a61b527b4e1f285d21b6e9e623dc45cf8bb391f Mon Sep 17 00:00:00 2001 |
| From: Julia Lawall <Julia.Lawall@lip6.fr> |
| Date: Sat, 27 Jan 2018 15:28:15 +0100 |
| Subject: drm/radeon: adjust tested variable |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Julia Lawall <Julia.Lawall@lip6.fr> |
| |
| commit 3a61b527b4e1f285d21b6e9e623dc45cf8bb391f upstream. |
| |
| Check the variable that was most recently initialized. |
| |
| The semantic match that finds this problem is as follows: |
| (http://coccinelle.lip6.fr/) |
| |
| // <smpl> |
| @@ |
| expression x, y, f, g, e, m; |
| statement S1,S2,S3,S4; |
| @@ |
| |
| x = f(...); |
| if (\(<+...x...+>\&e\)) S1 else S2 |
| ( |
| x = g(...); |
| | |
| m = g(...,&x,...); |
| | |
| y = g(...); |
| *if (e) |
| S3 else S4 |
| ) |
| // </smpl> |
| |
| Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/radeon/radeon_uvd.c |
| +++ b/drivers/gpu/drm/radeon/radeon_uvd.c |
| @@ -946,7 +946,7 @@ int radeon_uvd_calc_upll_dividers(struct |
| /* calc dclk divider with current vco freq */ |
| dclk_div = radeon_uvd_calc_upll_post_div(vco_freq, dclk, |
| pd_min, pd_even); |
| - if (vclk_div > pd_max) |
| + if (dclk_div > pd_max) |
| break; /* vco is too big, it has to stop */ |
| |
| /* calc score with current vco freq */ |
