| From foo@baz Thu Mar 22 14:57:32 CET 2018 |
| From: James Smart <jsmart2021@gmail.com> |
| Date: Fri, 21 Apr 2017 16:04:56 -0700 |
| Subject: Fix driver usage of 128B WQEs when WQ_CREATE is V1. |
| |
| From: James Smart <jsmart2021@gmail.com> |
| |
| |
| [ Upstream commit 3f247de750b8dd8f50a2c1390e2a1238790a9dff ] |
| |
| There are two versions of a structure for queue creation and setup that the |
| driver shares with FW. The driver was only treating as version 0. |
| |
| Verify WQ_CREATE with 128B WQEs in V0 and V1. |
| |
| Code review of another bug showed the driver passing |
| 128B WQEs and 8 pages in WQ CREATE and V0. |
| Code inspection/instrumentation showed that the driver |
| uses V0 in WQ_CREATE and if the caller passes queue->entry_size |
| 128B, the driver sets the hdr_version to V1 so all is good. |
| When I tested the V1 WQ_CREATE, the mailbox failed causing |
| the driver to unload. |
| |
| Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com> |
| Signed-off-by: James Smart <james.smart@broadcom.com> |
| Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/lpfc/lpfc_sli.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/scsi/lpfc/lpfc_sli.c |
| +++ b/drivers/scsi/lpfc/lpfc_sli.c |
| @@ -13493,6 +13493,9 @@ lpfc_wq_create(struct lpfc_hba *phba, st |
| case LPFC_Q_CREATE_VERSION_1: |
| bf_set(lpfc_mbx_wq_create_wqe_count, &wq_create->u.request_1, |
| wq->entry_count); |
| + bf_set(lpfc_mbox_hdr_version, &shdr->request, |
| + LPFC_Q_CREATE_VERSION_1); |
| + |
| switch (wq->entry_size) { |
| default: |
| case 64: |
