| From foo@baz Thu Mar 22 14:57:32 CET 2018 |
| From: Pan Bian <bianpan2016@163.com> |
| Date: Sun, 23 Apr 2017 20:04:04 +0800 |
| Subject: qlcnic: fix unchecked return value |
| |
| From: Pan Bian <bianpan2016@163.com> |
| |
| |
| [ Upstream commit 91ec701a553cb3de470fd471c6fefe3ad1125455 ] |
| |
| Function pci_find_ext_capability() may return 0, which is an invalid |
| address. In function qlcnic_sriov_virtid_fn(), its return value is used |
| without validation. This may result in invalid memory access bugs. This |
| patch fixes the bug. |
| |
| Signed-off-by: Pan Bian <bianpan2016@163.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c |
| +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c |
| @@ -127,6 +127,8 @@ static int qlcnic_sriov_virtid_fn(struct |
| return 0; |
| |
| pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_SRIOV); |
| + if (!pos) |
| + return 0; |
| pci_read_config_word(dev, pos + PCI_SRIOV_VF_OFFSET, &offset); |
| pci_read_config_word(dev, pos + PCI_SRIOV_VF_STRIDE, &stride); |
| |