| From a728a196d253530f17da5c86dc7dfbe58c5f7094 Mon Sep 17 00:00:00 2001 |
| From: Christian Lamparter <chunkeey@googlemail.com> |
| Date: Fri, 25 Aug 2017 15:47:14 +0200 |
| Subject: crypto: crypto4xx - remove bad list_del |
| |
| From: Christian Lamparter <chunkeey@googlemail.com> |
| |
| commit a728a196d253530f17da5c86dc7dfbe58c5f7094 upstream. |
| |
| alg entries are only added to the list, after the registration |
| was successful. If the registration failed, it was never added |
| to the list in the first place. |
| |
| Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Amit Pundir <amit.pundir@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/crypto/amcc/crypto4xx_core.c | 6 ++---- |
| 1 file changed, 2 insertions(+), 4 deletions(-) |
| |
| --- a/drivers/crypto/amcc/crypto4xx_core.c |
| +++ b/drivers/crypto/amcc/crypto4xx_core.c |
| @@ -1029,12 +1029,10 @@ int crypto4xx_register_alg(struct crypto |
| break; |
| } |
| |
| - if (rc) { |
| - list_del(&alg->entry); |
| + if (rc) |
| kfree(alg); |
| - } else { |
| + else |
| list_add_tail(&alg->entry, &sec_dev->alg_list); |
| - } |
| } |
| |
| return 0; |
