| From ac7f052b9e1534c8248f814b6f0068ad8d4a06d2 Mon Sep 17 00:00:00 2001 |
| From: Alexey Kuznetsov <kuznet@parallels.com> |
| Date: Tue, 19 Jul 2016 12:48:01 -0700 |
| Subject: fuse: fsync() did not return IO errors |
| |
| From: Alexey Kuznetsov <kuznet@parallels.com> |
| |
| commit ac7f052b9e1534c8248f814b6f0068ad8d4a06d2 upstream. |
| |
| Due to implementation of fuse writeback filemap_write_and_wait_range() does |
| not catch errors. We have to do this directly after fuse_sync_writes() |
| |
| Signed-off-by: Alexey Kuznetsov <kuznet@virtuozzo.com> |
| Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com> |
| Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> |
| Fixes: 4d99ff8f12eb ("fuse: Turn writeback cache on") |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/fuse/file.c | 15 +++++++++++++++ |
| 1 file changed, 15 insertions(+) |
| |
| --- a/fs/fuse/file.c |
| +++ b/fs/fuse/file.c |
| @@ -462,6 +462,21 @@ int fuse_fsync_common(struct file *file, |
| goto out; |
| |
| fuse_sync_writes(inode); |
| + |
| + /* |
| + * Due to implementation of fuse writeback |
| + * filemap_write_and_wait_range() does not catch errors. |
| + * We have to do this directly after fuse_sync_writes() |
| + */ |
| + if (test_bit(AS_ENOSPC, &file->f_mapping->flags) && |
| + test_and_clear_bit(AS_ENOSPC, &file->f_mapping->flags)) |
| + err = -ENOSPC; |
| + if (test_bit(AS_EIO, &file->f_mapping->flags) && |
| + test_and_clear_bit(AS_EIO, &file->f_mapping->flags)) |
| + err = -EIO; |
| + if (err) |
| + goto out; |
| + |
| err = sync_inode_metadata(inode, 1); |
| if (err) |
| goto out; |