| From 63d37fb4ce5ae7bf1e58f906d1bf25f036fe79b2 Mon Sep 17 00:00:00 2001 |
| From: Murphy Zhou <jencce.kernel@gmail.com> |
| Date: Sat, 21 Sep 2019 19:26:00 +0800 |
| Subject: CIFS: fix max ea value size |
| |
| From: Murphy Zhou <jencce.kernel@gmail.com> |
| |
| commit 63d37fb4ce5ae7bf1e58f906d1bf25f036fe79b2 upstream. |
| |
| It should not be larger then the slab max buf size. If user |
| specifies a larger size, it passes this check and goes |
| straightly to SMB2_set_info_init performing an insecure memcpy. |
| |
| Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> |
| Reviewed-by: Aurelien Aptel <aaptel@suse.com> |
| CC: Stable <stable@vger.kernel.org> |
| Signed-off-by: Steve French <stfrench@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/cifs/xattr.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/cifs/xattr.c |
| +++ b/fs/cifs/xattr.c |
| @@ -31,7 +31,7 @@ |
| #include "cifs_fs_sb.h" |
| #include "cifs_unicode.h" |
| |
| -#define MAX_EA_VALUE_SIZE 65535 |
| +#define MAX_EA_VALUE_SIZE CIFSMaxBufSize |
| #define CIFS_XATTR_CIFS_ACL "system.cifs_acl" |
| #define CIFS_XATTR_ATTRIB "cifs.dosattrib" /* full name: user.cifs.dosattrib */ |
| #define CIFS_XATTR_CREATETIME "cifs.creationtime" /* user.cifs.creationtime */ |
