| From 74ff094dea92974f665977935f64c8f001364759 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 23 Aug 2019 15:40:45 -0700 |
| Subject: f2fs: check all the data segments against all node ones |
| |
| From: Surbhi Palande <f2fsnewbie@gmail.com> |
| |
| [ Upstream commit 1166c1f2f69117ad254189ca781287afa6e550b6 ] |
| |
| As a part of the sanity checking while mounting, distinct segment number |
| assignment to data and node segments is verified. Fixing a small bug in |
| this verification between node and data segments. We need to check all |
| the data segments with all the node segments. |
| |
| Fixes: 042be0f849e5f ("f2fs: fix to do sanity check with current segment number") |
| Signed-off-by: Surbhi Palande <csurbhi@gmail.com> |
| Reviewed-by: Chao Yu <yuchao0@huawei.com> |
| Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/f2fs/super.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c |
| index 4ebe695724755..9eff18c1f3e46 100644 |
| --- a/fs/f2fs/super.c |
| +++ b/fs/f2fs/super.c |
| @@ -1557,11 +1557,11 @@ int sanity_check_ckpt(struct f2fs_sb_info *sbi) |
| } |
| } |
| for (i = 0; i < NR_CURSEG_NODE_TYPE; i++) { |
| - for (j = i; j < NR_CURSEG_DATA_TYPE; j++) { |
| + for (j = 0; j < NR_CURSEG_DATA_TYPE; j++) { |
| if (le32_to_cpu(ckpt->cur_node_segno[i]) == |
| le32_to_cpu(ckpt->cur_data_segno[j])) { |
| f2fs_msg(sbi->sb, KERN_ERR, |
| - "Data segment (%u) and Data segment (%u)" |
| + "Node segment (%u) and Data segment (%u)" |
| " has the same segno: %u", i, j, |
| le32_to_cpu(ckpt->cur_node_segno[i])); |
| return 1; |
| -- |
| 2.20.1 |
| |
