| From a643e44252554008695dddc07c1b289f88428838 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 27 Jun 2019 23:01:15 -0400 |
| Subject: media: exynos4-is: fix leaked of_node references |
| |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| |
| [ Upstream commit da79bf41a4d170ca93cc8f3881a70d734a071c37 ] |
| |
| The call to of_get_child_by_name returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| drivers/media/platform/exynos4-is/fimc-is.c:813:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function. |
| drivers/media/platform/exynos4-is/fimc-is.c:870:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function. |
| drivers/media/platform/exynos4-is/fimc-is.c:885:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function. |
| drivers/media/platform/exynos4-is/media-dev.c:545:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 541, but without a corresponding object release within this function. |
| drivers/media/platform/exynos4-is/media-dev.c:528:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 499, but without a corresponding object release within this function. |
| drivers/media/platform/exynos4-is/media-dev.c:534:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 499, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/platform/exynos4-is/fimc-is.c | 1 + |
| drivers/media/platform/exynos4-is/media-dev.c | 2 ++ |
| 2 files changed, 3 insertions(+) |
| |
| diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c |
| index 7f92144a1de3a..f9456f26ff4fa 100644 |
| --- a/drivers/media/platform/exynos4-is/fimc-is.c |
| +++ b/drivers/media/platform/exynos4-is/fimc-is.c |
| @@ -819,6 +819,7 @@ static int fimc_is_probe(struct platform_device *pdev) |
| return -ENODEV; |
| |
| is->pmu_regs = of_iomap(node, 0); |
| + of_node_put(node); |
| if (!is->pmu_regs) |
| return -ENOMEM; |
| |
| diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c |
| index 1a1154a9dfa49..ef6ccb5b89525 100644 |
| --- a/drivers/media/platform/exynos4-is/media-dev.c |
| +++ b/drivers/media/platform/exynos4-is/media-dev.c |
| @@ -494,6 +494,7 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd) |
| continue; |
| |
| ret = fimc_md_parse_port_node(fmd, port, index); |
| + of_node_put(port); |
| if (ret < 0) { |
| of_node_put(node); |
| goto rpm_put; |
| @@ -527,6 +528,7 @@ static int __of_get_csis_id(struct device_node *np) |
| if (!np) |
| return -EINVAL; |
| of_property_read_u32(np, "reg", ®); |
| + of_node_put(np); |
| return reg - FIMC_INPUT_MIPI_CSI2_0; |
| } |
| |
| -- |
| 2.20.1 |
| |
