| From 3428602ace739f9356b02563c5c0ee83ed372355 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 9 Aug 2019 16:40:35 +0200 |
| Subject: net: lpc-enet: fix printk format strings |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit de6f97b2bace0e2eb6c3a86e124d1e652a587b56 ] |
| |
| compile-testing this driver on other architectures showed |
| multiple warnings: |
| |
| drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_drv_probe': |
| drivers/net/ethernet/nxp/lpc_eth.c:1337:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] |
| |
| drivers/net/ethernet/nxp/lpc_eth.c:1342:19: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] |
| |
| Use format strings that work on all architectures. |
| |
| Link: https://lore.kernel.org/r/20190809144043.476786-10-arnd@arndb.de |
| Reported-by: kbuild test robot <lkp@intel.com> |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/nxp/lpc_eth.c | 13 +++++++------ |
| 1 file changed, 7 insertions(+), 6 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c |
| index 8e13ec84c5381..9fcaf19106335 100644 |
| --- a/drivers/net/ethernet/nxp/lpc_eth.c |
| +++ b/drivers/net/ethernet/nxp/lpc_eth.c |
| @@ -1374,13 +1374,14 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) |
| pldat->dma_buff_base_p = dma_handle; |
| |
| netdev_dbg(ndev, "IO address space :%pR\n", res); |
| - netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); |
| + netdev_dbg(ndev, "IO address size :%zd\n", |
| + (size_t)resource_size(res)); |
| netdev_dbg(ndev, "IO address (mapped) :0x%p\n", |
| pldat->net_base); |
| netdev_dbg(ndev, "IRQ number :%d\n", ndev->irq); |
| - netdev_dbg(ndev, "DMA buffer size :%d\n", pldat->dma_buff_size); |
| - netdev_dbg(ndev, "DMA buffer P address :0x%08x\n", |
| - pldat->dma_buff_base_p); |
| + netdev_dbg(ndev, "DMA buffer size :%zd\n", pldat->dma_buff_size); |
| + netdev_dbg(ndev, "DMA buffer P address :%pad\n", |
| + &pldat->dma_buff_base_p); |
| netdev_dbg(ndev, "DMA buffer V address :0x%p\n", |
| pldat->dma_buff_base_v); |
| |
| @@ -1427,8 +1428,8 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) |
| if (ret) |
| goto err_out_unregister_netdev; |
| |
| - netdev_info(ndev, "LPC mac at 0x%08x irq %d\n", |
| - res->start, ndev->irq); |
| + netdev_info(ndev, "LPC mac at 0x%08lx irq %d\n", |
| + (unsigned long)res->start, ndev->irq); |
| |
| phydev = ndev->phydev; |
| |
| -- |
| 2.20.1 |
| |
