| From 9002995f03b7c1d53eef9e2ded4230171bd79472 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 12 Sep 2018 19:48:30 -0500 |
| Subject: power: supply: sysfs: ratelimit property read error message |
| |
| From: David Lechner <david@lechnology.com> |
| |
| [ Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827 ] |
| |
| This adds rate limiting to the message that is printed when reading a |
| power supply property via sysfs returns an error. This will prevent |
| userspace applications from unintentionally dDOSing the system by |
| continuously reading a property that returns an error. |
| |
| Signed-off-by: David Lechner <david@lechnology.com> |
| Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/power/supply/power_supply_sysfs.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c |
| index c0fc98e03c912..85cb5b9c1b6f0 100644 |
| --- a/drivers/power/supply/power_supply_sysfs.c |
| +++ b/drivers/power/supply/power_supply_sysfs.c |
| @@ -84,7 +84,8 @@ static ssize_t power_supply_show_property(struct device *dev, |
| dev_dbg(dev, "driver has no data for `%s' property\n", |
| attr->attr.name); |
| else if (ret != -ENODEV && ret != -EAGAIN) |
| - dev_err(dev, "driver failed to report `%s' property: %zd\n", |
| + dev_err_ratelimited(dev, |
| + "driver failed to report `%s' property: %zd\n", |
| attr->attr.name, ret); |
| return ret; |
| } |
| -- |
| 2.20.1 |
| |