| From d88de040e1df38414fc1e4380be9d0e997ab4d58 Mon Sep 17 00:00:00 2001 |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Date: Thu, 4 Jun 2020 21:44:44 -0500 |
| Subject: iio: pressure: zpa2326: handle pm_runtime_get_sync failure |
| |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| |
| commit d88de040e1df38414fc1e4380be9d0e997ab4d58 upstream. |
| |
| Calling pm_runtime_get_sync increments the counter even in case of |
| failure, causing incorrect ref count. Call pm_runtime_put if |
| pm_runtime_get_sync fails. |
| |
| Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Fixes: 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support") |
| Cc: <Stable@vger.kernel.org> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/iio/pressure/zpa2326.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/iio/pressure/zpa2326.c |
| +++ b/drivers/iio/pressure/zpa2326.c |
| @@ -676,8 +676,10 @@ static int zpa2326_resume(const struct i |
| int err; |
| |
| err = pm_runtime_get_sync(indio_dev->dev.parent); |
| - if (err < 0) |
| + if (err < 0) { |
| + pm_runtime_put(indio_dev->dev.parent); |
| return err; |
| + } |
| |
| if (err > 0) { |
| /* |
