| From 000f64b87814202e6e2b7ce28d046ff3ec6e80f6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 7 Apr 2021 12:59:47 -0700 |
| Subject: dmaengine: idxd: fix wq size store permission state |
| |
| From: Dave Jiang <dave.jiang@intel.com> |
| |
| [ Upstream commit 0fff71c5a311e1264988179f7dcc217fda15fadd ] |
| |
| WQ size can only be changed when the device is disabled. Current code |
| allows change when device is enabled but wq is disabled. Change the check |
| to detect device state. |
| |
| Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of driver") |
| Signed-off-by: Dave Jiang <dave.jiang@intel.com> |
| Link: https://lore.kernel.org/r/161782558755.107710.18138252584838406025.stgit@djiang5-desk3.ch.intel.com |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/dma/idxd/sysfs.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c |
| index b3ab86ced355..ad46b3c648af 100644 |
| --- a/drivers/dma/idxd/sysfs.c |
| +++ b/drivers/dma/idxd/sysfs.c |
| @@ -923,7 +923,7 @@ static ssize_t wq_size_store(struct device *dev, |
| if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags)) |
| return -EPERM; |
| |
| - if (wq->state != IDXD_WQ_DISABLED) |
| + if (idxd->state == IDXD_DEV_ENABLED) |
| return -EPERM; |
| |
| if (size + total_claimed_wq_size(idxd) - wq->size > idxd->max_wq_size) |
| -- |
| 2.30.2 |
| |
