| From 5525c7ec3cf08f7fd6b0401fae2954dfb020d4c9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 21 Mar 2021 15:49:13 +0900 |
| Subject: lockdep: Add a missing initialization hint to the "INFO: Trying to |
| register non-static key" message |
| |
| From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
| |
| [ Upstream commit 3a85969e9d912d5dd85362ee37b5f81266e00e77 ] |
| |
| Since this message is printed when dynamically allocated spinlocks (e.g. |
| kzalloc()) are used without initialization (e.g. spin_lock_init()), |
| suggest to developers to check whether initialization functions for objects |
| were called, before making developers wonder what annotation is missing. |
| |
| [ mingo: Minor tweaks to the message. ] |
| |
| Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
| Signed-off-by: Ingo Molnar <mingo@kernel.org> |
| Link: https://lore.kernel.org/r/20210321064913.4619-1-penguin-kernel@I-love.SAKURA.ne.jp |
| Signed-off-by: Ingo Molnar <mingo@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| kernel/locking/lockdep.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c |
| index eead7efbe7e5..38d7c03e694c 100644 |
| --- a/kernel/locking/lockdep.c |
| +++ b/kernel/locking/lockdep.c |
| @@ -930,7 +930,8 @@ static bool assign_lock_key(struct lockdep_map *lock) |
| /* Debug-check: all keys must be persistent! */ |
| debug_locks_off(); |
| pr_err("INFO: trying to register non-static key.\n"); |
| - pr_err("the code is fine but needs lockdep annotation.\n"); |
| + pr_err("The code is fine but needs lockdep annotation, or maybe\n"); |
| + pr_err("you didn't initialize this object before use?\n"); |
| pr_err("turning off the locking correctness validator.\n"); |
| dump_stack(); |
| return false; |
| -- |
| 2.30.2 |
| |
